chore(release): pull main into develop post release v3.6.0 #1692
Conversation
MoumitaM
requested review from
ItsSudip,
shrouti1507,
sandeepdsvs,
koladilip and
a team
as code owners
WalkthroughThis update involves several packages within a project, mainly focusing on version increments and bug fixes. The core changes include updating versions from Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files ignored due to path filters (1)
Files selected for processing (16)
Files skipped from review due to trivial changes (6)
Additional comments not posted (17)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1692 +/- ##
===========================================
- Coverage 53.93% 53.92% -0.01%
===========================================
Files 461 461
Lines 15616 15615 -1
Branches 3098 3098
===========================================
- Hits 8422 8421 -1
- Misses 5878 5899 +21
+ Partials 1316 1295 -21 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Actionable comments outside the diff hunks (7)
packages/analytics-js-integrations/CHANGELOG_LATEST.md (1)
Line range hint
8-8: Please remove the extra blank line to maintain consistency and cleanliness in the document formatting.-packages/loading-scripts/CHANGELOG_LATEST.md (1)
Line range hint
11-11: Please remove the extra blank line to maintain consistency and cleanliness in the document formatting.-packages/analytics-js/CHANGELOG_LATEST.md (1)
Line range hint
9-9: Please remove the extra blank line to maintain consistency and cleanliness in the document formatting.-packages/loading-scripts/CHANGELOG.md (4)
Line range hint
123-123: Please correct the heading level to maintain a logical structure in the document. It should increment by one level at a time.- ### Bug Fixes + ## Bug Fixes
Line range hint
159-159: Please correct the heading level to maintain a logical structure in the document. It should increment by one level at a time.- ### Bug Fixes + ## Bug Fixes
Line range hint
40-40: Please remove the extra blank line to maintain consistency and cleanliness in the document formatting.-
Line range hint
59-59: Please remove the extra blank line to maintain consistency and cleanliness in the document formatting.-
| @@ -2,6 +2,13 @@ | |||
|
|
|||
| This file was generated using [@jscutlery/semver](https://github.com/jscutlery/semver). | |||
|
|
|||
| ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected]...@rudderstack/[email protected]) (2024-04-12) | |||
There was a problem hiding this comment.
Ensure consistent formatting for version links.
- ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected]...@rudderstack/[email protected]) (2024-04-12)
+ ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/v3.0.3...v3.0.4) (2024-04-12)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/analytics-js-integrations@3.0.3...@rudderstack/analytics-js-integrations@3.0.4) (2024-04-12) | |
| ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/v3.0.3...v3.0.4) (2024-04-12) |
|
|
||
| ### Bug Fixes | ||
|
|
||
| * remove unnecessary window globals declarations ([#1687](https://github.com/rudderlabs/rudder-sdk-js/issues/1687)) ([09e5ab8](https://github.com/rudderlabs/rudder-sdk-js/commit/09e5ab89965a0b0dc5070891288a08358c103c0e)) |
There was a problem hiding this comment.
Tip
Codebase Verification
The verification scripts have successfully confirmed that the commit link provided in the changelog is valid and accessible, as indicated by the HTTP status code 200. However, the issue link did not return a status code 200, suggesting that the issue might not be accessible or does not exist.
Given this information, it appears that while the commit related to the removal of unnecessary window globals is correctly documented, the issue link provided does not correctly detail or perhaps even relate to the changes made, as it is not accessible.
Action Required:
Please verify the correctness and accessibility of the issue link in the changelog entry. If the issue link is incorrect or the issue is private, it should be updated or clarified in the documentation.
Analysis chain
Bug fix for removing unnecessary window globals is well-documented. Ensure the linked issue and commit are relevant and correctly detail the changes made.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify the linked issue and commit are relevant and correctly detail the changes made.
curl -o /dev/null -s -w "%{http_code}\n" https://github.com/rudderlabs/rudder-sdk-js/issues/1687 | grep '200'
curl -o /dev/null -s -w "%{http_code}\n" https://github.com/rudderlabs/rudder-sdk-js/commit/09e5ab89965a0b0dc5070891288a08358c103c0e | grep '200'
Length of output: 259
| @@ -1,8 +1,7 @@ | |||
| ## [3.0.3](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected].2...@rudderstack/[email protected].3) (2024-04-02) | |||
| ## [3.0.4](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected].3...@rudderstack/[email protected].4) (2024-04-12) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please remove the extra blank line to maintain consistency and cleanliness in the document formatting.
- Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
|
|
||
| ### Dependency Updates | ||
|
|
There was a problem hiding this comment.
Please remove the extra blank line to maintain consistency and cleanliness in the document formatting.
- Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
|
size-limit report 📦
|
PR Description
Please include a summary of the change along with the relevant motivation and context.
Linear task (optional)
Linear task link
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit