From a0026152e4763569dc05693af1639e5a44d47b05 Mon Sep 17 00:00:00 2001 From: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com> Date: Wed, 3 Jul 2024 16:34:47 +0530 Subject: [PATCH 1/3] chore: revert fb pixel change --- .../data/FBPIXELCommonConfig.json | 5 - .../facebook_pixel/router/data.ts | 110 ------------------ 2 files changed, 115 deletions(-) diff --git a/src/v0/destinations/facebook_pixel/data/FBPIXELCommonConfig.json b/src/v0/destinations/facebook_pixel/data/FBPIXELCommonConfig.json index 1ba6c4c82f..11a81a20ab 100644 --- a/src/v0/destinations/facebook_pixel/data/FBPIXELCommonConfig.json +++ b/src/v0/destinations/facebook_pixel/data/FBPIXELCommonConfig.json @@ -33,10 +33,5 @@ "context.traits.action_source", "properties.action_source" ] - }, - { - "destKey": "advertiser_tracking_enabled", - "sourceKeys": "context.device.adTrackingEnabled", - "required": false } ] diff --git a/test/integrations/destinations/facebook_pixel/router/data.ts b/test/integrations/destinations/facebook_pixel/router/data.ts index 1d3b35b42a..c754ffdc61 100644 --- a/test/integrations/destinations/facebook_pixel/router/data.ts +++ b/test/integrations/destinations/facebook_pixel/router/data.ts @@ -202,114 +202,4 @@ export const data = [ }, }, }, - { - name: 'facebook_pixel', - description: - 'Test 1 : adTrackingEnabled is passed in context, advertiser_tracking_enabled set to true', - feature: 'router', - module: 'destination', - version: 'v0', - input: { - request: { - body: { - input: [ - { - message: { - anonymousId: 'c82cbdff-e5be-4009-ac78-cdeea09ab4b1', - destination_props: { Fb: { app_id: 'RudderFbApp' } }, - context: { - device: { - id: 'df16bffa-5c3d-4fbb-9bce-3bab098129a7R', - manufacturer: 'Xiaomi', - model: 'Redmi 6', - name: 'xiaomi', - adTrackingEnabled: true, - }, - network: { carrier: 'Banglalink' }, - os: { name: 'android', version: '8.1.0' }, - screen: { height: '100', density: 50 }, - traits: { - email: 'abc@gmail.com', - anonymousId: 'c82cbdff-e5be-4009-ac78-cdeea09ab4b1', - }, - }, - event: 'spin_result', - integrations: { All: true }, - message_id: 'a80f82be-9bdc-4a9f-b2a5-15621ee41df8', - properties: { revenue: 400, additional_bet_index: 0 }, - timestamp: '2023-10-14T15:46:51.693229+05:30', - type: 'track', - }, - metadata: { jobId: 1, userId: 'u1' }, - destination: { - Config: { - limitedDataUsage: true, - blacklistPiiProperties: [{ blacklistPiiProperties: '', blacklistPiiHash: false }], - removeExternalId: true, - accessToken: '09876', - pixelId: 'dummyPixelId', - eventsToEvents: [{ from: '', to: '' }], - eventCustomProperties: [{ eventCustomProperties: '' }], - valueFieldIdentifier: '', - advancedMapping: false, - whitelistPiiProperties: [{ whitelistPiiProperties: '' }], - }, - Enabled: true, - }, - }, - ], - destType: 'facebook_pixel', - }, - method: 'POST', - }, - }, - output: { - response: { - status: 200, - body: { - output: [ - { - batchedRequest: { - version: '1', - type: 'REST', - method: 'POST', - endpoint: 'https://graph.facebook.com/v18.0/dummyPixelId/events?access_token=09876', - headers: {}, - params: {}, - body: { - JSON: {}, - XML: {}, - JSON_ARRAY: {}, - FORM: { - data: [ - '{"user_data":{"em":"48ddb93f0b30c475423fe177832912c5bcdce3cc72872f8051627967ef278e08"},"event_name":"spin_result","event_time":1697278611,"advertiser_tracking_enabled":true,"action_source":"other","custom_data":{"additional_bet_index":0,"value":400}}', - ], - }, - }, - files: {}, - }, - metadata: [{ jobId: 1, userId: 'u1' }], - batched: false, - statusCode: 200, - destination: { - Config: { - limitedDataUsage: true, - blacklistPiiProperties: [{ blacklistPiiProperties: '', blacklistPiiHash: false }], - removeExternalId: true, - accessToken: '09876', - pixelId: 'dummyPixelId', - eventsToEvents: [{ from: '', to: '' }], - eventCustomProperties: [{ eventCustomProperties: '' }], - valueFieldIdentifier: '', - advancedMapping: false, - whitelistPiiProperties: [{ whitelistPiiProperties: '' }], - }, - Enabled: true, - }, - }, - ], - }, - }, - }, - }, ].map((d) => ({ ...d, mockFns })); From 73046cc6b9853dd29bdcce31f95b68b785a875f3 Mon Sep 17 00:00:00 2001 From: GitHub Actions Date: Wed, 3 Jul 2024 11:17:14 +0000 Subject: [PATCH 2/3] chore(release): 1.70.1 --- CHANGELOG.md | 2 ++ package-lock.json | 4 ++-- package.json | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index adb96e6d62..9c0bb79342 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. +### [1.70.1](https://github.com/rudderlabs/rudder-transformer/compare/v1.70.0...v1.70.1) (2024-07-03) + ## [1.70.0](https://github.com/rudderlabs/rudder-transformer/compare/v1.69.1...v1.70.0) (2024-07-01) diff --git a/package-lock.json b/package-lock.json index aaa0edfdd2..15a565263b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "rudder-transformer", - "version": "1.70.0", + "version": "1.70.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "rudder-transformer", - "version": "1.70.0", + "version": "1.70.1", "license": "ISC", "dependencies": { "@amplitude/ua-parser-js": "0.7.24", diff --git a/package.json b/package.json index cc35b1a43c..8cf611e249 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "rudder-transformer", - "version": "1.70.0", + "version": "1.70.1", "description": "", "homepage": "https://github.com/rudderlabs/rudder-transformer#readme", "bugs": { From ea427660846a4b94f64d73c9f44740730747060a Mon Sep 17 00:00:00 2001 From: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com> Date: Wed, 3 Jul 2024 16:52:49 +0530 Subject: [PATCH 3/3] chore: changelog update --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9c0bb79342..9b47af2d5c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file. See [standa ### [1.70.1](https://github.com/rudderlabs/rudder-transformer/compare/v1.70.0...v1.70.1) (2024-07-03) +### Bug Fixes + +* revert fb pixel change ([769161a](https://github.com/rudderlabs/rudder-transformer/commit/a0026152e4763569dc05693af1639e5a44d47b05)) + ## [1.70.0](https://github.com/rudderlabs/rudder-transformer/compare/v1.69.1...v1.70.0) (2024-07-01)