Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use check-local-archive-file instead of our verify-download? #14

Open
bo-tato opened this issue Feb 13, 2024 · 1 comment
Open

use check-local-archive-file instead of our verify-download? #14

bo-tato opened this issue Feb 13, 2024 · 1 comment

Comments

@bo-tato
Copy link
Collaborator

bo-tato commented Feb 13, 2024

I realized quicklisp already has a check-local-archive-file that is documented as verifying size and signature of downloaded files but actually only checks the size, not the signature. It does report better error information than we are reporting in verify-download, and when the check fails it offers a restart to "Delete the archive file and fetch it again". I'm thinking maybe instead of having our own verify-download function, we should just add the the md5 and sha1 signature checks as CLOS :after methods to check-local-archive-file, and the existing function will do the file length check. If that sounds reasonable I can make a PR for it

@rudolfochrist
Copy link
Owner

Yes. Sounds indeed reasonable. Please go ahead and create PRs for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants