-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GWT grammar incompatible with CoffeeScript #10
Comments
Docs in #12 |
@codelahoma Thanks for raising this issue and the effort you put in to find a workaround. It's kinda sad that CS reserved the very keywords that make GWT, well GWT. I'm not sure about the alternative grammar (sounds old-Englishy) but since you are the only one whos actually done any work to get JasmineSpecies working in CS, I'll buy that! I'll pull your changes in, test and merge them pretty soon. Again thanks for your contribution, it's greatly appreciated. I welcome any additional suggestions, criticisms and new ideas you may have. Cheers! |
I know what you mean about the alternatives, but those were the only ones I could come up with that a) worked in roughly the same sense as when/then and b) fit together thematically. |
Definitely man, I appreciate the effort and since its just you and I for now, let's go with it! |
Drat, I closed it by mistake again! |
Hold off on merging for a bit. I woke up with what might be a better idea this morning: adding a capitalized form of the grammar. It breaks the convention of only capitalizing class names, but as a DSL, I don't think the convention needs to apply to BDD keywords. I'll get it coded up and tested sometime this week. Thanks for the feedback. It feels good to be able to contribute. |
Ok, I shall wait for your signal. I'm glad you are full on for contributing. I'm stoked whenever someone is interested enough to give back to a project. Keeps me/the project going. |
While porting a jQuery plugin to CoffeeScript, I discovered your jasmine extensions and, more importantly, that the GWT grammar uses three CoffeeScript reserved words (
when
,then
, andand
) as function names.At the time, I just rewrote my spec to avoid jasmine-species, but now I've forked your project and added three new, and hopefully comparable, functions to the grammar:
whilst
,hence
, andlikewise
.I've updated the specs to match, and will submit a pull request shortly, noting the number in a comment on this issue.
Once I've updated the docs, I'll submit a pull request for that, as well.
The text was updated successfully, but these errors were encountered: