Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for l10n #15

Open
ericchaves opened this issue Mar 28, 2012 · 1 comment
Open

Add support for l10n #15

ericchaves opened this issue Mar 28, 2012 · 1 comment

Comments

@ericchaves
Copy link

Hy Rudy,

Since the GWT notation is commonly used as a partial documentation in agile software, I believe that supporting localization for the reports is a great feature. So I used Ely Grey's l10n library to add localization support for jasmine-species. If you feel this is a good contribution feel free to take a look in my fork at https://github.com/ericchaves/jasmine-species

I haven't made a pull request because I'm not really of a JS developer and therefore I'm not sure if my code is the best approach to it.

Best regards,

Eric.

@rudylattae
Copy link
Owner

Hi Eric,

Thanks for taking an interest in Jasmine Species. I have always wanted it
to support i18n however, I was waiting for the pivotal guys to implement it
in Jasmine so I could piggy back on their work.

I'm glad you took the initiative to work on this feature. I will look at
your fork soon and we can work on bringing this feature into the master
branch of the project.

Cheers,
Rudy
On Mar 28, 2012 9:00 AM, "Eric Paschoalick Chaves" <
[email protected]>
wrote:

Hy Rudy,

Since the GWT notation is commonly used as a partial documentation in
agile software, I believe that supporting localization for the reports is a
great feature. So I used Ely Grey's l10n library to add localization
support for jasmine-species. If you feel this is a good contribution feel
free to take a look in my fork at
https://github.com/ericchaves/jasmine-species

I haven't made a pull request because I'm not really of a JS developer and
therefore I'm not sure if my code is the best approach to it.

Best regards,

Eric.


Reply to this email directly or view it on GitHub:
#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants