Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Switch from PgTimestamp to SystemTime. #152

Open
farodin91 opened this issue Jan 6, 2017 · 5 comments
Open

Switch from PgTimestamp to SystemTime. #152

farodin91 opened this issue Jan 6, 2017 · 5 comments
Labels
component/database effort/normal status/accepted type/improvement

Comments

@farodin91
Copy link
Member

This would make calculations easier. It's also increase the support of different Database types. Diesel will start to support mysql in future.
@farodin91 farodin91 mentioned this issue Jan 6, 2017
Merged
@jimmycuadra
Copy link
Member

As long as Diesel supports SystemTime (which it looks like it does) this sounds good to me!

@mujx
Copy link

mujx commented Jan 17, 2017 •
edited
Loading

One problem that came up in #137 is how to go from seconds (u64 etc) to SystemTime so that can be used in diesel queries. Maybe there is a workaround? We used the time crate (which is really missing from the std) for the conversions.

@farodin91
Copy link
Member Author

Could be better to switch NaiveDateTime form chrono.

@mujx
Copy link

mujx commented Jan 17, 2017

In general we should try to eliminate u64 and i64 where we can when it comes to timestamps.

@jimmycuadra
Copy link
Member

chrono would be fine if the stdlib time APIs don't cut it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component/database effort/normal status/accepted type/improvement
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jimmycuadra @farodin91 @mujx