feat: add get_task_result_stream to new client #351
+204
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func: Callable[_P, AsyncGenerator[_G, None]], /, *args: Any, **kwargs: Any | ||
| ) -> Callable[_P, list[_G]]: | ||
| def new_func(*fargs: Any, **fkwargs: Any) -> list[_G]: | ||
| return asyncio.run(_async_gen_to_list(func(*fargs, **fkwargs))) |
There was a problem hiding this comment.
If there's already an event loop, this will fail without nest_asyncio
There was a problem hiding this comment.
Good catch. This line in particular is not even the problem, async_to_sync would raise a runtime error if you try to use the converted sync code in an async function within an existing loop (fair enough, why would you want all the overhead?). I added a check so it's our client raising RuntimeError now with a specific message explaining what's happening.
logan-markewich
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the last method missing from
AsyncSessionClient,get_task_result_stream.Fixes #335
Notes for the reviewer:
Coroutine[AsyncGenerator]when converted withasync_to_syncreturnAsyncGenerator, that we can't use in sync calls. To overcome this limitation,generator_wrapperwas added that consumes the async generator under the hood and returns a listClient