Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_topic generates invalid topic names for AWS SNS #446

Open
Tehsmash opened this issue Jan 30, 2025 · 0 comments
Open

get_topic generates invalid topic names for AWS SNS #446

Tehsmash opened this issue Jan 30, 2025 · 0 comments

Comments

@Tehsmash
Copy link
Contributor

AWS SNS topics can only have '-' and '_' in the name. https://aws.amazon.com/sns/faqs/#Features_and_functionality

The current code in BaseService and ControlPlaneServer generates topics like:

".<control plane / service name>"

replacing the '.' with an '-' works well, but then that might be incompatible with other message queues.

Perhaps passing the namespace and the service name to the "register_consumer" function on the message queue implementation would allow the different message queues to decide their own format?

@masci masci added this to Framework Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant