-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Qdrant fastembed sparse encoder model name typo #16493
Comments
Feel free to make a PR! |
Thanks Logan for your quick response, tried to push my branch, but got message saying "you don't have write access to run-llama/llama_index", is there a better way for me to create a PR, or how may I request write access? Thanks. In a separate thread regarding LanceDB, there is a bug I shared there earlier regarding issues in data ingestion process. Could you take a look when have time? Thank you. |
@manfredwang093 normally you need to fork the repo, push changes to your fork, and then propose a PR with your fork |
Thank you @logan-markewich , just opened this PR |
Bug Description
There is a typo in the default sparse encoder model name
there is an 'i' missing from
[prithivida/Splade_PP_en_v1](https://huggingface.co/prithivida/Splade_PP_en_v1)
llama_index/llama-index-integrations/vector_stores/llama-index-vector-stores-qdrant/llama_index/vector_stores/qdrant/utils.py
Line 68 in 58c00bd
def fastembed_sparse_encoder(
model_name: str = "prithvida/Splade_PP_en_v1",
batch_size: int = 256,
cache_dir: Optional[str] = None,
threads: Optional[int] = None,
) -> SparseEncoderCallable:
Version
0.11.17
Steps to Reproduce
llama_index/llama-index-integrations/vector_stores/llama-index-vector-stores-qdrant/llama_index/vector_stores/qdrant/utils.py
Line 68 in 58c00bd
Relevant Logs/Tracbacks
No response
The text was updated successfully, but these errors were encountered: