Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Qdrant fastembed sparse encoder model name typo #16493

Closed
manfredwang093 opened this issue Oct 10, 2024 · 5 comments · Fixed by #16494
Closed

[Bug]: Qdrant fastembed sparse encoder model name typo #16493

manfredwang093 opened this issue Oct 10, 2024 · 5 comments · Fixed by #16494
Labels
bug Something isn't working triage Issue needs to be triaged/prioritized

Comments

@manfredwang093
Copy link
Contributor

manfredwang093 commented Oct 10, 2024

Bug Description

There is a typo in the default sparse encoder model name

there is an 'i' missing from [prithivida/Splade_PP_en_v1](https://huggingface.co/prithivida/Splade_PP_en_v1)

def fastembed_sparse_encoder(
model_name: str = "prithvida/Splade_PP_en_v1",
batch_size: int = 256,
cache_dir: Optional[str] = None,
threads: Optional[int] = None,
) -> SparseEncoderCallable:

Version

0.11.17

Steps to Reproduce

Relevant Logs/Tracbacks

No response

@manfredwang093 manfredwang093 added bug Something isn't working triage Issue needs to be triaged/prioritized labels Oct 10, 2024
Copy link

dosubot bot commented Oct 10, 2024

There is indeed a typo in the fastembed_sparse_encoder function. The model name should be "prithivida/Splade_PP_en_v1" instead of "prithvida/Splade_PP_en_v1" [1].

To continue talking to Dosu, mention @dosu.

@logan-markewich
Copy link
Collaborator

Feel free to make a PR!

@manfredwang093
Copy link
Contributor Author

Thanks Logan for your quick response, tried to push my branch, but got message saying "you don't have write access to run-llama/llama_index", is there a better way for me to create a PR, or how may I request write access? Thanks.

In a separate thread regarding LanceDB, there is a bug I shared there earlier regarding issues in data ingestion process. Could you take a look when have time? Thank you.
#14435 (comment)

@logan-markewich
Copy link
Collaborator

@manfredwang093 normally you need to fork the repo, push changes to your fork, and then propose a PR with your fork

@manfredwang093
Copy link
Contributor Author

@manfredwang093 normally you need to fork the repo, push changes to your fork, and then propose a PR with your fork

Thank you @logan-markewich , just opened this PR
#16494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Issue needs to be triaged/prioritized
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants