-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Delete not yet implemented for Faiss index. #6250
Comments
Actually, faiss index is currently broken with the latest File "/home/jonch/Desktop/Programming/mlsys/llama_index/llama_index/vector_stores/faiss.py", line 105, in add
self._faiss_index.add_with_ids(text_embedding_np)
TypeError: handle_Index.<locals>.replacement_add_with_ids() missing 1 required positional argument: 'ids' It is currently not a dep of |
Hi, @LF112! I'm Dosu, and I'm here to help the LlamaIndex team manage their backlog. I wanted to let you know that we are marking this issue as stale. From what I understand, you requested a delete function for nodes in the FAISS index used by Llama Index. You were wondering when this function would be implemented and if there is an alternative way to delete nodes in FAISS. There is also a comment from user "jon-chuang" mentioning that the FAISS index is currently broken with the latest version and suggesting to add a working version as an optional dependency. Another user "nandhakumarsoliton" is facing the same issue and requesting a delete feature in FAISS. They also mention an error they encountered when trying to delete nodes. Before we proceed, could you please confirm if this issue is still relevant to the latest version of the LlamaIndex repository? If it is, please let us know by commenting on this issue. Otherwise, feel free to close the issue yourself or it will be automatically closed in 7 days. Thank you for your understanding and cooperation. We appreciate your contribution to LlamaIndex! Best regards, |
Hey, how did you resolve this issue? I'm facing the same. |
I did not solve this issue...it was automatically closed by the @dosubot |
The delete functionality for FAISS in the LlamaIndex codebase is not yet implemented. The To continue talking to Dosu, mention @dosu. Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other |
@logan-markewich, the user LF112 has indicated that the issue regarding the deletion of nodes from FAISS is still relevant and needs attention. They mentioned encountering an error with the |
Feature Description
When I use the delete_ref_doc index node deletion method provided by GPTVectorStoreIndex, I get an error: "Delete not yet implemented for Faiss index."
When will the function to delete a node from FAISS be implemented?
Is there an alternative way to delete FAISS nodes?
https://github.com/jerryjliu/llama_index/blob/main/llama_index/vector_stores/faiss.py#L142
Reason
Llama Index does not currently have a function to delete nodes from FAISS.
Value of Feature
The delete function is a key part of the process.
The text was updated successfully, but these errors were encountered: