Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package strayr, port strayr functions, and update package documentation for changes #35

Closed
2 tasks done
wfmackey opened this issue May 30, 2021 · 9 comments
Closed
2 tasks done
Assignees

Comments

@wfmackey
Copy link
Collaborator

wfmackey commented May 30, 2021

re #20 . @MattCowgill will port mattcowgill/strayr functions.

  • port strayr functions
  • rename package
@MattCowgill
Copy link
Collaborator

FYI @bryceroney as a contributor to strayr, just letting you know that we're going to:

  1. Rename abscorr to strayr; and
  2. Bring in all the functions from the existing strayr package (including yours related to public holidays) to this package.

@bryceroney
Copy link
Contributor

No dramas @MattCowgill. I'll put in a PR to update the pkgdown site to include the references.

@wfmackey
Copy link
Collaborator Author

Repo renamed! Hopefully it won't break anything, but I am sorry when it inevitably does.

@daviddiviny daviddiviny reopened this May 31, 2021
@daviddiviny
Copy link
Collaborator

I've re-opened this issue @wfmackey as there seem to be a bunch of strayr eferences to the old name of abscorr (e.g. here).

I'm not sure of the systematic way to do this but this blogpost from runapp-er njtierney looks useful.

@wfmackey
Copy link
Collaborator Author

Yep sorry, jumped the gun there. I will make those changes tonight.

@wfmackey wfmackey changed the title Rename package strayr and port strayr functions Rename package strayr, port strayr functions, and update package documentation for changes May 31, 2021
wfmackey pushed a commit that referenced this issue May 31, 2021
@wfmackey
Copy link
Collaborator Author

This has been done in #42

@daviddiviny
Copy link
Collaborator

Does Matt's github somehow need to mirror the runapp-aus version?

@MattCowgill
Copy link
Collaborator

not sure how to do that... rename my existing repo and fork this repo?

@bryceroney
Copy link
Contributor

You could archive the repository, given the README points people to the new repo.

JustGitting pushed a commit to JustGitting/strayr that referenced this issue Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants