Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support persistent_disk_type input in atlantis module #158

Closed
knjoroge opened this issue Jul 22, 2024 · 2 comments · Fixed by #161
Closed

Support persistent_disk_type input in atlantis module #158

knjoroge opened this issue Jul 22, 2024 · 2 comments · Fixed by #161
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers patch A minor, backward compatible change under-consideration Indicates that the topic or suggestion is actively being reviewed and considered for implementation.

Comments

@knjoroge
Copy link

knjoroge commented Jul 22, 2024 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.

Hello,

It would be nice to have persistent_disk_type as an input in the atlantis module as not everyone has a use case where they need a SSD provisioned.

https://github.com/runatlantis/terraform-gce-atlantis?tab=readme-ov-file#inputs

https://cloud.google.com/compute/docs/disks#introduction
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer label Jul 22, 2024
@knjoroge knjoroge changed the title Support persistent_disk_type as input in atlantis module Support persistent_disk_type input in atlantis module Jul 22, 2024
@bschaatsbergen
Copy link
Member

Great feature request @knjoroge - thank you for taking the time to raise this issue.

@bschaatsbergen bschaatsbergen added documentation Improvements or additions to documentation good first issue Good for newcomers patch A minor, backward compatible change under-consideration Indicates that the topic or suggestion is actively being reviewed and considered for implementation. and removed needs-triage Waiting for first response or review from a maintainer labels Jul 23, 2024
@d-costa d-costa mentioned this issue Aug 6, 2024
Merged
@knjoroge
Copy link
Author

knjoroge commented Aug 7, 2024

@d-costa @bschaatsbergen thank you! Do you know when you're planning to have this released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers patch A minor, backward compatible change under-consideration Indicates that the topic or suggestion is actively being reviewed and considered for implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add persistent_disk_type variable nosportugal/terraform-gce-atlantis
2 participants
@knjoroge @bschaatsbergen