Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash extraction fails #18

Open
finnlindgren opened this issue Feb 6, 2022 · 1 comment · May be fixed by #20
Open

Hash extraction fails #18

finnlindgren opened this issue Feb 6, 2022 · 1 comment · May be fixed by #20

Comments

@finnlindgren
Copy link

finnlindgren commented Feb 6, 2022

The commit aca8e78 that was meant to fix parts of #17 seems to revert parts of the previous fix for extraction, causing it to fail. With the latest learnr devel, learnrhash::extract_hash fails due to a missing "id" column.
In addition, from what I can tell, the "exercise_submission" type used for extract_exercises was the old name (and similar for questions); the previous commit for fixing extractions changed it to "exercise" and "question", which was fine up until this latest "fix".
So it looks to me that the latest fix regressed to some old learnr format, rather than updating it to the latest.

I'm now trying to force my quizzes to load the previous learnrhash version, and that still works with the latest learnr devel version.

@finnlindgren
Copy link
Author

finnlindgren commented Feb 6, 2022

Here's a demo with the latest version, showing that the type field contains "exercise" and "question", and not "exercise_submission":
https://uoe-maths.shinyapps.io/StatCompQuizDemoDebug/#section-submit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant