Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove infiniteGas from example #15

Closed
palinatolmach opened this issue Oct 8, 2023 · 1 comment · Fixed by #35
Closed

Remove infiniteGas from example #15

palinatolmach opened this issue Oct 8, 2023 · 1 comment · Fixed by #35
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@palinatolmach
Copy link
Contributor

Infinite gas is now used by default in Kontrol, so providing kevm.infiniteGas() cheatcode is no longer necessary, so we should remove if from the example CounterTest contract we use in the documentation: https://docs.runtimeverification.com/kontrol/guides/kevm-foundry-integration-example/property-verification-using-kevm. The nodes corresponding to the kevm.infiniteGas() call will no longer be present in the KCFG, so it will require updates in the KCFG section too.

@JuanCoRo JuanCoRo self-assigned this Oct 9, 2023
@yale-vinson yale-vinson added the documentation Improvements or additions to documentation label Oct 9, 2023
@JuanCoRo
Copy link
Member

The status of this issue is that it explicitly says that the example of the infiniteGas() is merely for ilustration purposes since it's redundant to include it. Following #21, we should have a section on cheatocdes and create exples for the most used ones.

I think the only remaining action to do before closing the issue would be to update the screenshots for the code without the infiniteGas cheatcode, since that's the version that will stand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants