Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible implies endpoint not giving correct result #3605

Open
nwatson22 opened this issue Jun 15, 2023 · 2 comments · May be fixed by #3620
Open

Possible implies endpoint not giving correct result #3605

nwatson22 opened this issue Jun 15, 2023 · 2 comments · May be fixed by #3620
Labels

Comments

@nwatson22
Copy link
Member

I have a simple configuration with just a k cell and a Map.

  configuration <T color="yellow">
                  <k> $PGM:Pgm </k>
                  <state> .Map </state>
                </T>

And am passing in something that looks like this (before being converted to kore)

antecedent: <generatedTop>
  <T>
    <k>
      K_CELL
    </k>
    <state>
      STATE_CELL
    </state>
  </T>
  <generatedCounter>
    GENERATEDCOUNTER_CELL
  </generatedCounter>
</generatedTop>
consequent: #Exists X . #Exists Y . <generatedTop>
  <T>
    <k>
      K_CELL
    </k>
    <state>
      STATE_CELL
    </state>
  </T>
  <generatedCounter>
    GENERATEDCOUNTER_CELL
  </generatedCounter>
</generatedTop>
#And { true #Equals 0 >Int Y }
#And { true #Equals 0 <=Int X }

with the goal of figuring out if { true #Equals 0 >Int Y } #And { true #Equals 0 <=Int X } is satisfiable, and the endpoint returns satisfiable=false. In #3601 it is mentioned that this satisfiable field should actually be called "valid", but I thought this implication should actually be valid because { true #Equals 0 >Int Y } #And { true #Equals 0 <=Int X } is satisfiable and the variables X and Y are existentially quantified. It's possible I'm just not using the endpoint correctly or am not understanding something matching-logic related.

bug_report.tar.gz

@goodlyrottenapple
Copy link
Contributor

I wonder if this is the culprit:

rhsBottom <-
fmap isBottom . liftSimplifier $
SMT.Evaluator.filterMultiOr $srcLoc
=<< Pattern.simplify right

we are calling simplify on the rhs without the existential quantifiers here

@goodlyrottenapple
Copy link
Contributor

the above, together with #3193 are causing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants