Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate source code #4022

Closed
tothtamas28 opened this issue Feb 21, 2024 · 4 comments · Fixed by #4263
Closed

Consolidate source code #4022

tothtamas28 opened this issue Feb 21, 2024 · 4 comments · Fixed by #4263
Assignees

Comments

@tothtamas28
Copy link
Contributor

Merge

kernel
├── pom.xml
└── src
    ├── main
    │   ├── java
    │   ├── javacc
    │   ├── jjtree
    │   └── resources
    └── test
        ├── java
        └── resources

and

kore
├── build.sbt
├── pom.xml
├── project
│   └── build.sbt
└── src
    ├── main
    │   ├── java
    │   └── scala
    └── test
        ├── java
        └── scala

into

k-frontend
├── build.sbt
├── pom.xml
└── src
    ├── main
    │   ├── java
    │   ├── javacc
    │   ├── jjtree
    │   ├── resources
    │   └── scala
    └── test
        ├── java
        ├── resources
        └── scala
@Baltoli
Copy link
Contributor

Baltoli commented Feb 21, 2024

After we discussed this, I remembered that one reason for the split is that the kore part is somehow published and consumed by the LLVM backend: https://github.com/runtimeverification/llvm-backend/blob/d3c1ee78a4235661c5e00f29fe89e1ec5f632afb/matching/pom.xml#L35-L39

@Baltoli
Copy link
Contributor

Baltoli commented Feb 22, 2024

  • When building the K frontend, the LLVM backend's POM will point upwards in the tree to get the KORE dependency.
  • When building the LLVM backend independently:
    • Will pull first from your local maven repository
    • Otherwise we push in the K release job

@Baltoli
Copy link
Contributor

Baltoli commented Feb 22, 2024

We can also remove the SBT files; we no longer use those.

@Baltoli
Copy link
Contributor

Baltoli commented Mar 20, 2024

I think this is blocked on #4041 - @Scott-Guest when we get the Java 17 support merged across the Scala-using modules, is there anything else blocking us from merging these packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants