New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date#to_date , DateTime#to_date, #to_datetime #2848

Open

foomin10 opened this issue Nov 27, 2023 · 0 comments · May be fixed by #2872

Contributor

foomin10 commented Nov 27, 2023

Date
- Date#to_date
- (Date#to_datetime)
DateTime
- DateTime#to_date
- DateTime#to_datetime

Date#to_date は、self を返していますので「self を返します。」と記載すべきだと思います。RDoc においても「Returns self.」と書かれています。

ただし、この修正だけだと Date を継承する DateTime の同名のメソッドの説明が間違ってしまいますので、DateTime#to_date も必要です。

また、DateTime#to_datetime も「self を返します。」として記載が必要です。

The text was updated successfully, but these errors were encountered:

foomin10 changed the title ~~Date#to_date , DateTime#{to_date, #to_datetime~~ Date#to_date , DateTime#to_date, #to_datetime

foomin10 linked a pull request

that will close this issue

Update to_date, to_datetime and to_time #2872

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment