You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That really not intuitive when you are expected std nomenclature and it's more logical to return it as std do it. Plus, I think this function should return either a Result or a Option (like std should) to avoid unexpected panic.
I don't think there's an issue with take_split, it's consistent with the rest of nom. Could you avoid opening an issue then immediately opening a PR for an architecture change or new feature without waiting for my opinion? This was not necessary
take_split()
doesn't precise what is returned and implementation do:That really not intuitive when you are expected std nomenclature and it's more logical to return it as std do it. Plus, I think this function should return either a Result or a Option (like std should) to avoid unexpected panic.
Open rust-lang/rust#90410.
The text was updated successfully, but these errors were encountered: