New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI script uses env vars incorrectly #236

Open

tcharding opened this issue Aug 15, 2022 · 0 comments

Member

tcharding commented Aug 15, 2022

In the CI script we have

if [ -n "$RUSTFMTCHECK" ]; then
  rustup component add rustfmt
  cargo fmt --all -- --check
fi

and in the pipeline we set RUSTFMTCHECK = false

Setting the env var to false makes the if statement true so the formatter is run, likely this is not whats intended.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment