Cleanup Cargo features and optionals #494
Conversation
nyurik
commented
Sep 1, 2023
nyurik
commented
- Make sure all optional dependencies are not exposed automatically, but rather explicit
| @@ -14,6 +14,7 @@ categories = [ | |||
| [features] | |||
| std = ["alloc"] | |||
| alloc = [] | |||
| defmt-03 = ["dep:defmt-03"] | |||
There was a problem hiding this comment.
IIUC this is equivalent to the old code. Why is it better?
There was a problem hiding this comment.
I believe this is better because it makes defmt-03 feature declaration explicit for anyone looking at cargo.toml -- one can see all features at a glance. It also means that if additional dependencies are needed for the defmt-03 feature, they can be simply listed at the end of the list. In short, I prefer this form simply to follow Rust-way of "no implicit surprises" :)
There was a problem hiding this comment.
A bit redundant but I sympathize with the case of seeing all features at a glance.
* Make sure all optional dependencies are not exposed automatically, but rather explicit
| @@ -14,6 +14,7 @@ categories = [ | |||
| [features] | |||
| std = ["alloc"] | |||
| alloc = [] | |||
| defmt-03 = ["dep:defmt-03"] | |||
There was a problem hiding this comment.
A bit redundant but I sympathize with the case of seeing all features at a glance.
