Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tree closing and opening #207

Closed
Kobzol opened this issue Mar 4, 2025 · 2 comments · Fixed by #223
Closed

Implement tree closing and opening #207

Kobzol opened this issue Mar 4, 2025 · 2 comments · Fixed by #223
Labels
good first issue Good for newcomers

Comments

@Kobzol
Copy link
Contributor

Kobzol commented Mar 4, 2025

homu has a command closed @bors treeclosed=<p> and @bors treeclosed-, which close and open the tree, respectively.

A closed for priority P tree means that no PR with priority less than P won't be attempted to be merged.

Bors can't currently do merges, but we could implement parsing of the command, checking of permissions etc. We will also need to store this information in the DB somewhere, because it is attached to a repository, rather than to a PR, so we will need to represent repositories in the DB somehow.

It would be great to check out how homu does this.
@Kobzol Kobzol added the good first issue Good for newcomers label Mar 4, 2025
@Rhythm1710
Copy link
Contributor

Can I work on this?

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 4, 2025

Sure :)

@Rhythm1710 Rhythm1710 mentioned this issue Mar 5, 2025
Closed
@Kobzol Kobzol mentioned this issue Mar 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tree Closing and Opening Rhythm1710/bors
2 participants
@Kobzol @Rhythm1710