Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow approving only some part of the tree #33

Open
Kobzol opened this issue Jul 10, 2023 · 2 comments
Open

Allow approving only some part of the tree #33

Kobzol opened this issue Jul 10, 2023 · 2 comments
Labels
idea Just an idea, probably should not be implemented at the moment.

Comments

@Kobzol
Copy link
Contributor

Kobzol commented Jul 10, 2023

It could be nice to have granular permissions and allow some users to r+ only some subdirectory of the repository.

@Sakib25800
Copy link
Contributor

I was thinking about trying to implement this but I don't know what structure to go for? I'm assuming this will be a configurable option within rust-bots.toml.

Structure I had in mind:

[permissions]
"src/web" = ["ghusername", "user2"]
"src/api" = ["ghusername1", "ghusername"]
"docs/" = ["docs-team"]
"src/**" = ["ghusername3"]

Would the above be a good structure / supported configuration?

@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 25, 2025

To be honest, I would put this to the backburner for now. It's an idea that has been floated around, but it needs a lot of discussions with infra and the various teams, and changes in https://github.com/rust-lang/team. We can talk about this once bors is actually working, but for now it is premature.

@Kobzol Kobzol added the idea Just an idea, probably should not be implemented at the moment. label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Just an idea, probably should not be implemented at the moment.
Projects
None yet
Development

No branches or pull requests

2 participants