Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take increasingly bigger steps #276

Open
matthiaskrgr opened this issue Apr 22, 2023 · 3 comments
Open

take increasingly bigger steps #276

matthiaskrgr opened this issue Apr 22, 2023 · 3 comments
Labels
A-bisection-algorithm Area: The bisection algorithm enhancement New feature or request

Comments

@matthiaskrgr
Copy link
Member

After some time, bisect will always check 2 rust versions per month as it goes back in time, but when bisecting stable-to-stable regressions, this still takes a lot of time. It would be nice if could perhaps try to go back by one month at a time a year after the first checked commit and maybe 1.5 months after 2 years? (or just increase the number of days skipped linearly with the further back we go?)

@oli-obk
Copy link
Contributor

oli-obk commented Apr 22, 2023

we could also just go back exponentially by default and then do a normal bisection when we hit a change

@Mark-Simulacrum
Copy link
Member

The choice here was intentional, in my experience the farther back you go the more likely it is that you stop building for different reasons (typically dropping back before the relevant feature is supported), meaning that the "did it build" function is not monotonic, which means you can't bisect: you have bad commits both at the beginning and the end of your curve, which prevents the typical binary search from working.

We can tweak the exact constant, but I would avoid trying anything exponential - that goes too quickly, in my experience.

@matthiaskrgr
Copy link
Member Author

Could be behind an extra cmdline flag.
From doing a couple bisections today i already got around 100 bisector toolchains installed which seems like quite a lot .

@ehuss ehuss added enhancement New feature or request A-bisection-algorithm Area: The bisection algorithm labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-bisection-algorithm Area: The bisection algorithm enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants