Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bisecting broken: Script returned error #343

Open
matthiaskrgr opened this issue Jun 23, 2024 · 5 comments
Open

bisecting broken: Script returned error #343

matthiaskrgr opened this issue Jun 23, 2024 · 5 comments

Comments

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Jun 23, 2024

I have a script like

#!/bin/sh
! rustc /tmp/crash.rs  |& grep -Ii "query stack"

which returns 1 or 0 depending on whether rustc says "query stack" while processing a file.

When I try to run this after the update
cargo-bisect-rustc --preserve --script=/home/matthias/vcs/github/rust_bisect/script.sh --test-dir=/home/matthias/vcs/github/rust_bisect/foo --start 2024-06-15
CBR just quits:

fetching https://static.rust-lang.org/dist/channel-rust-nightly-date.txt
nightly date: 10 B / 10 B [===========================================================================================================] 100.00 % 755.04 KB/s determined the latest nightly is 2024-06-23
checking the start range to find a passing nightly
installing nightly-2024-06-15
testing...
RESULT: nightly-2024-06-15, ===> Script returned error

ERROR: the start of the range (nightly-2024-06-15) must not reproduce the regression

cc @ehuss

cargo-bisect-rustc 0.6.9

@ehuss
Copy link
Collaborator

ehuss commented Jun 23, 2024

Can you say more about what the issue is? It looks like the start of your range is either failing to compile, or emitting the "query stack" message. What are the contents of crash.rs? What is the output with -vv?

@matthiaskrgr
Copy link
Member Author

Ooh, did only the CBR output change?
This looked like cbr could not proceed because of some error related to the script.

@ehuss
Copy link
Collaborator

ehuss commented Jun 23, 2024

Yea, instead of saying "Yes" or "No", it tells you what happened at each step.

@matthiaskrgr
Copy link
Member Author

would be clearer if it would also say the exit code imo, something like
Script returned error (exit code: 1)

@ehuss
Copy link
Collaborator

ehuss commented Jun 24, 2024

Yea, it would be nice to include the exit code. I'm not sure how difficult that will be since the code that renders the message may not have access to the exit code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants