Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing multiple packages should not say “You may press ctrl-c to skip waiting” #15005

Open
kpreid opened this issue Jan 2, 2025 · 1 comment
Labels
C-bug Category: bug Command-publish S-triage Status: This issue is waiting on initial triage. Z-package-workspace Nightly: package-workspace

Comments

@kpreid
Copy link
Contributor

kpreid commented Jan 2, 2025

Problem

When using the new unstable support for publishing multiple packages in one command, Cargo prints its usual message during uploading:

You may press ctrl-c to skip waiting; the crate should be available shortly.

However, this does not make sense for any packages but the last one, because the only things it could possibly do are cancel the remaining packages (unwanted), run the risk of erroring out due to not waiting before publishing the next package (unwanted), or do nothing (misleading).

Possible Solution(s)

Cargo should not print this message. Perhaps a more useful while-you-wait message would be to report how many packages remain to be published (or how many have been and the total).

Notes

@rustbot label +Z-package-workspace

Version

cargo 1.85.0-nightly (d73d2caf9 2024-12-31)
release: 1.85.0-nightly
commit-hash: d73d2caf9e41a39daf2a8d6ce60ec80bf354d2a7
commit-date: 2024-12-31
host: aarch64-apple-darwin
libgit2: 1.8.1 (sys:0.19.0 vendored)
libcurl: 8.7.1 (sys:0.4.74+curl-8.9.0 system ssl:(SecureTransport) LibreSSL/3.3.6)
ssl: OpenSSL 1.1.1w  11 Sep 2023
os: Mac OS 15.2.0 [64-bit]
@kpreid kpreid added C-bug Category: bug S-triage Status: This issue is waiting on initial triage. labels Jan 2, 2025
@rustbot rustbot added the Z-package-workspace Nightly: package-workspace label Jan 2, 2025
@epage
Copy link
Contributor

epage commented Jan 2, 2025

The first question is if the message is serving its purpose.

If so, then it would be needed in these cases. What could instead work is to re-word it to tell users that the current package would be available shortly but that there are X packages that are unpublished.

The message was added in #11230 (though started in #11062) and tweaked in #11713. Neither seems to talk about the motivation. #11062 initially didn't call out ctrl-c but I'm not seeing the discussion where it changed. I also checked meeting notes from that time and I'm not seeing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug Command-publish S-triage Status: This issue is waiting on initial triage. Z-package-workspace Nightly: package-workspace
Projects
None yet
Development

No branches or pull requests

3 participants