Skip to content

Replace i586 ceil and floor implementations with assembly to fix +/-0 #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tgross35 opened this issue Jan 6, 2025 · 0 comments
Open

Replace i586 ceil and floor implementations with assembly to fix +/-0 #837

tgross35 opened this issue Jan 6, 2025 · 0 comments
Labels
libm Issues relating to libm

Comments

@tgross35
Copy link
Contributor

tgross35 commented Jan 6, 2025

From rust-lang/libm#404 (comment):

i think for i586 it should just use frndint with setting the x87 CW (actually not slow) for floor/ceil. like: https://github.com/NetBSD/src/blob/20433927938987dd64c8f6aa46904b7aca3fa39e/lib/libm/arch/i387/s_ceil.S
@tgross35 tgross35 mentioned this issue Jan 6, 2025
Merged
@tgross35 tgross35 transferred this issue from rust-lang/libm Apr 19, 2025
@tgross35 tgross35 added the libm Issues relating to libm label Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libm Issues relating to libm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tgross35