Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFI upgrade golang version to >= 1.19 #119

Closed
neonphog opened this issue Jan 18, 2023 · 7 comments
Closed

FFI upgrade golang version to >= 1.19 #119

neonphog opened this issue Jan 18, 2023 · 7 comments

Comments

@neonphog
Copy link
Contributor

https://docs.rs/crate/tx5-go-pion-sys/0.0.1-alpha.1/builds/723243

[INFO] [stderr]   thread 'main' panicked at 'go executable version must be >= 1.19, got: 1.13', build.rs:42:5
@neonphog
Copy link
Contributor Author

Why is ubuntu's golang so old? Would it be possible to switch to jammy? That at least has 1.17 (https://packages.ubuntu.com/jammy/golang-1.17] I might be able to pair back the deps that far.

@syphar
Copy link
Member

syphar commented Jan 18, 2023

We're tracking ubuntu LTS for these images.

A upgrade to jammy is possible, but is some work (see also #84 ).

I'm happy to review a PR :)

@neonphog
Copy link
Contributor Author

I assume you meant see also #84. Awesome I'll spend a little time on that today.

@syphar
Copy link
Member

syphar commented Jan 18, 2023

oh yeah, you're right :)

@syphar
Copy link
Member

syphar commented Jan 21, 2023

I assume the golang version is now up-to-date with the new image (#120) and will close this issue.

Thank you!

@syphar syphar closed this as completed Jan 21, 2023
@neonphog
Copy link
Contributor Author

Yep, build env is now up to go 1.18, and I was able to reduce the requirement down to 1.18. Thanks for your help!

@syphar
Copy link
Member

syphar commented Jan 21, 2023

Thank you for yours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants