From ebbc6be1b72b70af33e37f4106a66f8872e8c1cb Mon Sep 17 00:00:00 2001 From: Taiki Endo Date: Wed, 23 Jan 2019 19:11:16 +0900 Subject: [PATCH] Remove #[allow(clippy::new_ret_no_self)] --- futures-channel/src/mpsc/queue.rs | 1 - futures-executor/src/thread_pool.rs | 1 - futures-util/src/lock/bilock.rs | 1 - 3 files changed, 3 deletions(-) diff --git a/futures-channel/src/mpsc/queue.rs b/futures-channel/src/mpsc/queue.rs index 191db4a65c..94e86686d4 100644 --- a/futures-channel/src/mpsc/queue.rs +++ b/futures-channel/src/mpsc/queue.rs @@ -81,7 +81,6 @@ unsafe impl Send for Queue { } unsafe impl Sync for Queue { } impl Node { - #[allow(clippy::new_ret_no_self)] unsafe fn new(v: Option) -> *mut Node { Box::into_raw(Box::new(Node { next: AtomicPtr::new(ptr::null_mut()), diff --git a/futures-executor/src/thread_pool.rs b/futures-executor/src/thread_pool.rs index 74f99f9faf..1820e20b11 100644 --- a/futures-executor/src/thread_pool.rs +++ b/futures-executor/src/thread_pool.rs @@ -72,7 +72,6 @@ impl ThreadPool { /// See documentation for the methods in /// [`ThreadPoolBuilder`](ThreadPoolBuilder) for details on the default /// configuration. - #[allow(clippy::new_ret_no_self)] pub fn new() -> Result { ThreadPoolBuilder::new().create() } diff --git a/futures-util/src/lock/bilock.rs b/futures-util/src/lock/bilock.rs index d02412f8c8..f5d8c61c9f 100644 --- a/futures-util/src/lock/bilock.rs +++ b/futures-util/src/lock/bilock.rs @@ -59,7 +59,6 @@ impl BiLock { /// will only be available through `Pin<&mut T>` (not `&mut T`) unless `T` is `Unpin`. /// Similarly, reuniting the lock and extracting the inner value is only /// possible when `T` is `Unpin`. - #[allow(clippy::new_ret_no_self)] pub fn new(t: T) -> (BiLock, BiLock) { let arc = Arc::new(Inner { state: AtomicUsize::new(0),