Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support git_commit_create_cb in RebaseOptions #850

Open
CouleeApps opened this issue Jun 22, 2022 · 3 comments · May be fixed by #1047
Open

Support git_commit_create_cb in RebaseOptions #850

CouleeApps opened this issue Jun 22, 2022 · 3 comments · May be fixed by #1047

Comments

@CouleeApps
Copy link

Currently, the RebaseOptions structure is missing support for commit_create_cb from the git_rebase_options C structure, which is used to facilitate things like commit signing in rebase operations. It would be useful to have safe access to this field to allow for custom commit signing abilities for rebase operations. It looks like the git_rebase_options structure has a payload field at the end which can be used for maintaining state across the FFI boundary, so implementation is hopefully not too complicated.

Followup discussion: signing_cb is also unimplemented, but marked as deprecated in the libgit2 C api. As such, it does not seem necessary to me to implement support for it. commit_create_cb seems to supersede its functionality.

@Pranav2612000
Copy link

I need this feature for something I'm working on. Would love to add it if its something the maintainers are okay with.

@extrawurst
Copy link
Contributor

@Pranav2612000 just open a PR 👍

@Pranav2612000
Copy link

@extrawurst Just got around to looking at the issue. I've opened up a PR - #1047 Can you help with the review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants