You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the RebaseOptions structure is missing support for commit_create_cb from the git_rebase_options C structure, which is used to facilitate things like commit signing in rebase operations. It would be useful to have safe access to this field to allow for custom commit signing abilities for rebase operations. It looks like the git_rebase_options structure has a payload field at the end which can be used for maintaining state across the FFI boundary, so implementation is hopefully not too complicated.
Followup discussion: signing_cb is also unimplemented, but marked as deprecated in the libgit2 C api. As such, it does not seem necessary to me to implement support for it. commit_create_cb seems to supersede its functionality.
The text was updated successfully, but these errors were encountered:
Currently, the
RebaseOptions
structure is missing support forcommit_create_cb
from thegit_rebase_options
C structure, which is used to facilitate things like commit signing in rebase operations. It would be useful to have safe access to this field to allow for custom commit signing abilities for rebase operations. It looks like thegit_rebase_options
structure has apayload
field at the end which can be used for maintaining state across the FFI boundary, so implementation is hopefully not too complicated.Followup discussion:
signing_cb
is also unimplemented, but marked as deprecated in the libgit2 C api. As such, it does not seem necessary to me to implement support for it.commit_create_cb
seems to supersede its functionality.The text was updated successfully, but these errors were encountered: