Add an optional logger param #664
Open
+164
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
tisonkun
force-pushed
the
logger-field
branch
from
155a28d to
2851f2b
Compare
Signed-off-by: tison <[email protected]>
tisonkun
commented
Feb 1, 2025
tests/integration.rs
Outdated
There was a problem hiding this comment.
This is just a good target to test our new logger param.
Previously, the global logger state is shared with all the macros tests and causes the result unstable.
tisonkun
commented
Feb 1, 2025
Signed-off-by: tison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #645
@KodrAus I noticed that we previously introduced
targetfor similar usage, but switching to a different logger is different.This patch is for preview. I'm not quite sure how we pass the customized logger. The current implementation seems good. I think the
logcrate itself isn't suitable to hold a globalname -> loggerregistry: that would be too heavy and too specific.