-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 Dark and Light Image Variants #2225
base: master
Are you sure you want to change the base?
Conversation
This had incremental work toward an image variant solution
This reverts commit 3d4721f. I'm trying to get the diffs smaller. It looks like someone previously committed code that did not strip extra spaces from the ends of lines with their editor.
Thanks, this looks interesting! I'm a little concerned about hard-coding the themes, as this won't work if the user adds their own themes. The |
This picks up pull request #1991 but implements a different light/dark mode variant that should be easier in markdown.
Writers can append
#only-light
or#only-dark
to the end of an image path:... which renders:
short-dark-light-mode-variant-demo.mp4