Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use axum for "mdbook serve" #2359

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

audunhalland
Copy link

@audunhalland audunhalland commented Apr 7, 2024

This in my opinion brings mdbook's dependencies more in line with "the state of the art" of the Rust HTTP ecosystem.
It pulls in hyper v1 and uses tower-http for filesystem serving functions.

I've manually tested serve with the test_book:

  • serving pages from the book works
  • websocket-based auto-reload works
  • 404 page works

I can't guarantee though that there are no regressions. I did not find integrations tests for the serve command.

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Apr 7, 2024
@paolobarbolini
Copy link

FWIW this seems the right call, as warp is still on hyper v0.14 and looking at their repository it gets almost no maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants