From 6cf4aa5d7a8b77d4a31fe656e4f4d96950350565 Mon Sep 17 00:00:00 2001 From: Ed Page Date: Mon, 13 Nov 2023 14:42:59 -0600 Subject: [PATCH] fix: Typo Co-authored-by: Weihang Lo --- text/3516-public-private-dependencies.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/text/3516-public-private-dependencies.md b/text/3516-public-private-dependencies.md index 753fe1349d2..fb0f7ed751f 100644 --- a/text/3516-public-private-dependencies.md +++ b/text/3516-public-private-dependencies.md @@ -245,7 +245,7 @@ You can't definitively lint when a `public = true` is unused since it may depend - `rustc`: Instead of `allow` by default for pre-2024 editions, we could warn by default - More people would get the benefit of the feature now - However, this would be extremely noisy and likely make people grumpy - - If we did this, we'd likely want to not require an MSRV bump so people can immediately silence the warning which would require using a key besides `public` (since its already reserved) and treating the field as an unused key when the `-Z` isn't enabled. + - If we did this, we'd likely want to not require an MSRV bump so people can immediately silence the warning which would require using a key besides `public` (since it's already reserved) and treating the field as an unused key when the `-Z` isn't enabled. - `Cargo.toml`: Instead of `public = false` being the default and changing the warning level on an edition boundary, we could instead start with `public = true` and change the default on an edition boundary. - This would require `cargo fix` marking all dependencies as `public = true`, while using the warning means we can limit it to only those dependencies that need it. - `Cargo.toml`: Instead of `public = false` being the default, we could have a "unchecked" / "unset" state