From 85d3dbf6b80a0bdd0651d577bbde157ba6fc2435 Mon Sep 17 00:00:00 2001 From: yegeunyang Date: Sun, 26 Jan 2025 03:41:28 -0600 Subject: [PATCH] change to span_lint_and_help --- clippy_lints/src/deref_coercions.rs | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/clippy_lints/src/deref_coercions.rs b/clippy_lints/src/deref_coercions.rs index 0871f5fa4ab3..ff095b8c5faf 100644 --- a/clippy_lints/src/deref_coercions.rs +++ b/clippy_lints/src/deref_coercions.rs @@ -1,6 +1,4 @@ -use clippy_utils::diagnostics::span_lint_and_sugg; -use clippy_utils::source::snippet_with_applicability; -use rustc_errors::Applicability; +use clippy_utils::diagnostics::span_lint_and_help; use rustc_hir::*; use rustc_lint::{LateContext, LateLintPass}; use rustc_middle::ty::adjustment::Adjust; @@ -33,21 +31,18 @@ declare_lint_pass!(DerefCoercions => [DEREF_COERCIONS]); impl LateLintPass<'_> for DerefCoercions { fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) { - let mut applicability = Applicability::MachineApplicable; - let snippet = snippet_with_applicability(cx, expr.span, "..", &mut applicability); let source = cx.typeck_results().expr_ty(expr).peel_refs(); for adjustment in cx.typeck_results().expr_adjustments(expr) { if let Adjust::Deref(_) = adjustment.kind && adjustment.target.peel_refs() != source { - span_lint_and_sugg( + span_lint_and_help( cx, DEREF_COERCIONS, expr.span, "implicit deref coercion", - "consider using `deref()`", - format!("{snippet}.deref()"), - applicability, + None, + "consider using `deref() or deref_mut()`", ); } }