Skip to content

Lint when > or >= is used i.e. compared values are not listed in (number line) order #13082

Open
@Skgland

Description

@Skgland

What it does

Check that < and <= are used rather than > or >= so that compared values are listed in order.

Advantage

Drawbacks

  • Its rather opinionated so should probably be allow by default style/pedantic lint
  • inversion might not be possible if only the PartialEq impl for one direction is implemented, so it might need to be limited to cases where the operands implement Eq

Example

Could be written as:

if val >= min && max >= val {
    // do something
}
if min <= val && val <= max {
    // do something
}

Preferably it would also recognize common operands so that

if val <= max && min <= val {
    // do something
}
if max <= val || val <= min {
    // do something
}

would become

if min <= val && val <= max {
    // do something
}
if val <= min && max <= val {
    // do something
}

i.e. for && move common value to the operator and for || move common value away from the operator

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-lintArea: New lints

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions