Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit macro checks and see if they can ignore desugarings #4083

Open
Manishearth opened this issue May 12, 2019 · 0 comments
Open

Audit macro checks and see if they can ignore desugarings #4083

Manishearth opened this issue May 12, 2019 · 0 comments

Comments

@Manishearth
Copy link
Member

#4080 made all macro checks ignore desugarings. But sometimes this ends up breaking things, like #4081, where the ? operator is creating an into() conversion that we catch.

#4082 moves almost all the macro checks back to checking for desugarings. We should audit these -- in most cases the macro is not checking anything that can potentially be tripped by code from a desugaring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant