Add goal to stabilize rustdoc doc_cfg feature
#324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
stabilize-doc-cfg
branch
from
d356240 to
2a62549
Compare
Manishearth
approved these changes
Jun 27, 2025
lqd
reviewed
Jul 18, 2025
src/2025h2/rustdoc-doc-cfg.md
Outdated
|
|
||
| | Task | Owner(s) or team(s) | Notes | | ||
| |-------------------------------|---------------------|-------| | ||
| | Merge [#138907][#138907] | rustdoc | | |
There was a problem hiding this comment.
Team asks have a certain format to be recognized by the tooling to create RFCs and such.
Suggested change
| | Merge [#138907][#138907] | rustdoc | | | |
| | Standard reviews | ![Team][] [rustdoc] | Merge [#138907] | |
lqd
reviewed
Jul 18, 2025
src/2025h2/rustdoc-doc-cfg.md
Outdated
| | Zulip channel | [#t-rustdoc][t-rustdoc] | | ||
|
|
||
| [t-rustdoc]: https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc | ||
| [rust-lang/rust#43781]: https://github.com/rust-lang/rust/issues/43781 |
There was a problem hiding this comment.
Suggested change
| [rust-lang/rust#43781]: https://github.com/rust-lang/rust/issues/43781 |
src/2025h2/rustdoc-doc-cfg.md
Outdated
| | Enable it by default on docs.rs | @GuillaumeGomez | | | ||
| | Send pull request to stabilize the feature | @GuillaumeGomez | | | ||
|
|
||
| [#138907]: https://github.com/rust-lang/rust/pull/138907 |
There was a problem hiding this comment.
Suggested change
| [#138907]: https://github.com/rust-lang/rust/pull/138907 |
GuillaumeGomez
force-pushed
the
stabilize-doc-cfg
branch
from
2a62549 to
24a61eb
Compare
|
Thanks! Applied suggestion and CI is now happy. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @rust-lang/rustdoc
Rendered