Skip to content

Commit 8423e00

Browse files
committed
Add a tidy check for leading trailing newlines
1 parent c21fbfe commit 8423e00

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

src/tools/tidy/src/style.rs

+7
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ pub fn check(path: &Path, bad: &mut bool) {
112112
let skip_length = contents.contains("ignore-tidy-linelength");
113113
let skip_end_whitespace = contents.contains("ignore-tidy-end-whitespace");
114114
let skip_copyright = contents.contains("ignore-tidy-copyright");
115+
let mut leading_new_lines = false;
115116
let mut trailing_new_lines = 0;
116117
for (i, line) in contents.split('\n').enumerate() {
117118
let mut err = |msg: &str| {
@@ -152,11 +153,17 @@ pub fn check(path: &Path, bad: &mut bool) {
152153
err(LLVM_UNREACHABLE_INFO);
153154
}
154155
if line.is_empty() {
156+
if i == 0 {
157+
leading_new_lines = true;
158+
}
155159
trailing_new_lines += 1;
156160
} else {
157161
trailing_new_lines = 0;
158162
}
159163
}
164+
if leading_new_lines {
165+
tidy_error!(bad, "{}: leading newline", file.display());
166+
}
160167
match trailing_new_lines {
161168
0 => tidy_error!(bad, "{}: missing trailing newline", file.display()),
162169
1 | 2 => {}

0 commit comments

Comments
 (0)