-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue-111508-vec-tryinto-array.rs fails spuriously on x86_64-gnu-llvm-19 #130656
Comments
Also failed in #127546 (comment) and #123778 (comment). |
We should remove this test and reopen the issue, especially if it's true that nobody understands why the codegen improved: #111508 (comment) |
"Nobody understands" as in "nobody bothered to run a bisect". This test has been consistently passing with our own LLVM 19 builds, so it's pretty weird that it fails with Ubuntu's. |
@nikic is it possible that a commit was merged in the past... uhh... 5 months that fixed a behavior that affects this? I think that Ubuntu's LLVM 19 may actually be a snapshot from April. |
That would certainly be bad -- where did you find that it is from April? It looks like Ubuntu 24.10 has the final release since yesterday: https://launchpad.net/ubuntu/+source/llvm-toolchain-19/1:19.1.0-1ubuntu1 I can't find a history on their website though. Possibly just regenerating the docker image will fix this issue. |
The log from #129974 has:
So the docker image should currently have rc4, which is close to what our fork currently uses. |
ah, I misunderstood something, then. I was looking at their "llvm-toolchain-snapshot" and trying to figure out its relationships to their other llvm repos and which branch would be in use: https://launchpad.net/ubuntu/+source/llvm-toolchain-snapshot and I was having trouble finding the version string in the log, too. it seems it isn't always printed? |
I've tried running this test in a loop in the x86_64-gnu-llvm-19 docker container and it never failed :( So no idea what's going on here. |
Yes, I tried similar antics right before I put up the PR to remove it. I actually probably would have left it if I could have reproduced a failure, because then I'd have any hope of it actually being solved by anything except magic. |
On #130389 this test failed, then passed, then failed. That PR modified rustc_codegen_llvm, so maybe it's a problem with the PR, but...
On #130641 the test failed as well. And LLVM update should have no impact on the llvm-19 job, so this is an unrelated failure.
Test: https://github.com/rust-lang/rust/blob/master/tests/codegen/issues/issue-111508-vec-tryinto-array.rs
The text was updated successfully, but these errors were encountered: