Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for amdgpu target #135024

Open
3 of 12 tasks
Flakebi opened this issue Jan 2, 2025 · 0 comments
Open
3 of 12 tasks

Tracking Issue for amdgpu target #135024

Flakebi opened this issue Jan 2, 2025 · 0 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC O-amdgpu AMDGPU targets T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Flakebi
Copy link
Contributor

Flakebi commented Jan 2, 2025

This issue tracks the implementation of the amdgpu target.

Old, closed tracking issue: #51575

Current work-in-progress branch: https://github.com/Flakebi/rust/tree/amdgpu

Implementation

Bugs

  • Debug compilation fails due to a bug in LLVM’s AMDGPUResourceUsageAnalysis. This is fixed in llvm main, so will be fixed with the update to LLVM 20
@Flakebi Flakebi added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Jan 2, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 2, 2025
…=compiler-errors

Remove range-metadata amdgpu workaround

Range metadata was disabled for amdgpu due to a backend bug. I did not encounter any problems when removing the workaround to enable range metadata (tried compiling `core` and `alloc`), so I assume this has been fixed in LLVM in the last years.

Remove the workaround to re-enable range metadata.

Tracking issue: rust-lang#135024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 2, 2025
Rollup merge of rust-lang#135027 - Flakebi:remove-range-workaround, r=compiler-errors

Remove range-metadata amdgpu workaround

Range metadata was disabled for amdgpu due to a backend bug. I did not encounter any problems when removing the workaround to enable range metadata (tried compiling `core` and `alloc`), so I assume this has been fixed in LLVM in the last years.

Remove the workaround to re-enable range metadata.

Tracking issue: rust-lang#135024
@workingjubilee workingjubilee added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. O-amdgpu AMDGPU targets A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. labels Jan 14, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 14, 2025
…gjubilee

Add gpu-kernel calling convention

The amdgpu-kernel calling convention was reverted in commit f6b21e9 (rust-lang#120495 and rust-lang/rust-analyzer#16463) due to inactivity in the amdgpu target.

Introduce a `gpu-kernel` calling convention that translates to `ptx_kernel` or `amdgpu_kernel`, depending on the target that rust compiles for.

Tracking issue: rust-lang#135467
amdgpu target tracking issue: rust-lang#135024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 14, 2025
…gjubilee

Add gpu-kernel calling convention

The amdgpu-kernel calling convention was reverted in commit f6b21e9 (rust-lang#120495 and rust-lang/rust-analyzer#16463) due to inactivity in the amdgpu target.

Introduce a `gpu-kernel` calling convention that translates to `ptx_kernel` or `amdgpu_kernel`, depending on the target that rust compiles for.

Tracking issue: rust-lang#135467
amdgpu target tracking issue: rust-lang#135024
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 17, 2025
…ubilee

Add gpu-kernel calling convention

The amdgpu-kernel calling convention was reverted in commit f6b21e9 (rust-lang#120495 and rust-lang/rust-analyzer#16463) due to inactivity in the amdgpu target.

Introduce a `gpu-kernel` calling convention that translates to `ptx_kernel` or `amdgpu_kernel`, depending on the target that rust compiles for.

Tracking issue: rust-lang#135467
amdgpu target tracking issue: rust-lang#135024
bjorn3 pushed a commit to bjorn3/rust that referenced this issue Jan 20, 2025
…ubilee

Add gpu-kernel calling convention

The amdgpu-kernel calling convention was reverted in commit f6b21e9 (rust-lang#120495 and rust-lang/rust-analyzer#16463) due to inactivity in the amdgpu target.

Introduce a `gpu-kernel` calling convention that translates to `ptx_kernel` or `amdgpu_kernel`, depending on the target that rust compiles for.

Tracking issue: rust-lang#135467
amdgpu target tracking issue: rust-lang#135024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC O-amdgpu AMDGPU targets T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants