Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new build_helper::compiletest module for safer invocations of compiletest by bootstrap #135645

Open
lolbinarycat opened this issue Jan 17, 2025 · 1 comment · May be fixed by #135653
Open

new build_helper::compiletest module for safer invocations of compiletest by bootstrap #135645

lolbinarycat opened this issue Jan 17, 2025 · 1 comment · May be fixed by #135653
Assignees
@lolbinarycat
Labels
A-compiletest Area: The compiletest test runner C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@lolbinarycat
Copy link
Contributor

currently bootstrap just uses strings to represent various compiletest arguments, such as mode.

obviously it would be better to use enums for these, as they are much less vulnerable to typos.

compiletest already has enum definitions for these (in common.rs), and the two already have a shared dependency (build_helper), and build_helper already has access to serde.

i would be willing to work on this refactor, if people think it would be a good idea.
@lolbinarycat lolbinarycat added A-compiletest Area: The compiletest test runner C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 17, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 17, 2025
@onur-ozkan
Copy link
Member

It would definitely be good to have a stricter type mechanism that is shared between bootstrap and compiletest.

@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 17, 2025
@lolbinarycat lolbinarycat self-assigned this Jan 17, 2025
@lolbinarycat lolbinarycat linked a pull request Jan 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lolbinarycat lolbinarycat

Labels
A-compiletest Area: The compiletest test runner C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build_helper::compiletest module factored out of compiletest for use by bootstrap lolbinarycat/rust
3 participants
@lolbinarycat @onur-ozkan @rustbot