Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README after submodule change #1052

Open
pierwill opened this issue Feb 12, 2021 · 2 comments
Open

Update README after submodule change #1052

pierwill opened this issue Feb 12, 2021 · 2 comments
Labels
A-meta Area: meta, about rustc or rustc-dev-guide itself C-CI Category: CI for this repo I-outdated Issue: info is outdated WG-rustc-dev-guide Working group: rustc-dev-guide

Comments

@pierwill
Copy link
Member

pierwill commented Feb 12, 2021 •
edited
Loading

Given the removal of the guide as a rust submodule in rust-lang/rust#81848, will the instructions at the bottom of this repo's README need updating?
@JohnTitor
Copy link
Member

The submodule has been removed and added (for link-checking) several times. But given CI here is enough now and we haven't checked it since about a year ago, I think we could also remove the instructions, even right now.

@jieyouxu jieyouxu added A-meta Area: meta, about rustc or rustc-dev-guide itself I-outdated Issue: info is outdated C-CI Category: CI for this repo WG-rustc-dev-guide Working group: rustc-dev-guide labels Nov 2, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Nov 2, 2024

Triage: still outdated, linkcheck is currently disabled, r-l/r has periodical submodule bump PRs e.g. rust-lang/rust#131369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-meta Area: meta, about rustc or rustc-dev-guide itself C-CI Category: CI for this repo I-outdated Issue: info is outdated WG-rustc-dev-guide Working group: rustc-dev-guide
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pierwill @JohnTitor @jieyouxu