Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Nov 1, 2025

This is a subset of #2039 that I'm most confident in that it is correct.

@Kobzol Kobzol changed the title Backfill missing Zulip IDs based on GitHub account association Backfill missing Zulip IDs based on GitHub account association and user comments Nov 1, 2025
@Kobzol Kobzol force-pushed the backfill-gh-zulip-association branch from 60d24e8 to 0988eb9 Compare November 1, 2025 09:53
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Repo Diffs:
    📝 Editing repo 'rust-analyzer/countme':
      Unarchive

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark [AUTO-SPOT-CHECK 1/5]: Randomly picking some profiles to spot-check ✅

Basically, I removed their people/ entry then re-run cargo add --fetch-zulip-id $GITHUB_HANDLE to see if their github-id and zulip-id entries match with the diff.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark [AUTO-SPOT-CHECK 2/5]: Randomly picking some profiles to spot-check ✅

This one I had to manually check, since cargo run add-person --fetch-zulip-id didn't work here as their zulip profile didn't have an associated github handle.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark [AUTO-SPOT-CHECK 3/5]: Randomly picking some profiles to spot-check ✅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark [AUTO-SPOT-CHECK 4/5]: Randomly picking some profiles to spot-check ✅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark [AUTO-SPOT-CHECK 5/5]: Randomly picking some profiles to spot-check ✅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: I manually checked that these correspond to the zulip-ids reported by contributors in #2040.

@jieyouxu jieyouxu added needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels Nov 1, 2025
@jieyouxu jieyouxu added this pull request to the merge queue Nov 1, 2025
Merged via the queue into rust-lang:master with commit 918a650 Nov 1, 2025
3 checks passed
@Kobzol Kobzol deleted the backfill-gh-zulip-association branch November 1, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants