-
Notifications
You must be signed in to change notification settings - Fork 326
Backfill missing Zulip IDs based on GitHub account association and user comments #2050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backfill missing Zulip IDs based on GitHub account association and user comments #2050
Conversation
60d24e8 to
0988eb9
Compare
Dry-run check results |
jieyouxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark [AUTO-SPOT-CHECK 1/5]: Randomly picking some profiles to spot-check ✅
Basically, I removed their people/ entry then re-run cargo add --fetch-zulip-id $GITHUB_HANDLE to see if their github-id and zulip-id entries match with the diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark [AUTO-SPOT-CHECK 2/5]: Randomly picking some profiles to spot-check ✅
This one I had to manually check, since cargo run add-person --fetch-zulip-id didn't work here as their zulip profile didn't have an associated github handle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark [AUTO-SPOT-CHECK 3/5]: Randomly picking some profiles to spot-check ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark [AUTO-SPOT-CHECK 4/5]: Randomly picking some profiles to spot-check ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark [AUTO-SPOT-CHECK 5/5]: Randomly picking some profiles to spot-check ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark: I manually checked that these correspond to the zulip-ids reported by contributors in #2040.
This is a subset of #2039 that I'm most confident in that it is correct.