Skip to content

Commit d5e07ab

Browse files
authored
Merge pull request #1703 from rust-osdev/bishop-unpin-night
Fix lints/tests on nightly and unpin the CI nightly version
2 parents 5d233a5 + e24491f commit d5e07ab

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
[toolchain]
2-
channel = "nightly-2025-06-01"
2+
channel = "nightly"
33
targets = ["aarch64-unknown-uefi", "i686-unknown-uefi", "x86_64-unknown-uefi"]

uefi-test-runner/src/proto/driver.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ use uefi::proto::driver::ComponentName1;
1212
/// `ComponentName`.
1313
trait ComponentNameInterface: Sized {
1414
fn open(handle: Handle) -> Result<Self>;
15-
fn supported_languages(&self) -> core::result::Result<LanguageIter, LanguageError>;
15+
fn supported_languages(&self) -> core::result::Result<LanguageIter<'_>, LanguageError>;
1616
fn driver_name(&self, language: &str) -> Result<&CStr16>;
1717
fn controller_name(
1818
&self,

uefi/src/mem/memory_map/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ mod tests_mmap_artificial {
107107
use super::*;
108108
use core::mem::{size_of, size_of_val};
109109

110-
fn buffer_to_map(buffer: &mut [MemoryDescriptor]) -> MemoryMapRefMut {
110+
fn buffer_to_map(buffer: &mut [MemoryDescriptor]) -> MemoryMapRefMut<'_> {
111111
let mmap_len = size_of_val(buffer);
112112
let mmap = {
113113
unsafe { core::slice::from_raw_parts_mut(buffer.as_mut_ptr().cast::<u8>(), mmap_len) }

xtask/src/cargo.rs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,16 @@ impl Cargo {
322322
rustflags.push_str(" --verbose");
323323
cmd.env("RUSTFLAGS", rustflags);
324324
}
325+
326+
// Skip the uefi-macros compilation "ui" tests on the nightly
327+
// toolchain. These tests are sensitive to compiler version, and
328+
// sometimes the output on nightly doesn't match the stable
329+
// toolchain.
330+
let toolchain = env::var("RUSTUP_TOOLCHAIN").unwrap_or_default();
331+
if toolchain.starts_with("nightly-") {
332+
println!("skipping uefi-macros ui tests for toolchain {toolchain}");
333+
tool_args.extend(["--skip", "ui"]);
334+
}
325335
}
326336
};
327337
cmd.arg(action);

0 commit comments

Comments
 (0)