Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a Different Zip Crate for Decompression #156

Open
lolpro11 opened this issue Feb 6, 2024 · 3 comments
Open

Use a Different Zip Crate for Decompression #156

lolpro11 opened this issue Feb 6, 2024 · 3 comments

Comments

@lolpro11
Copy link

lolpro11 commented Feb 6, 2024

Hi,
On PR #153 @Tristramg mentioned support of various zip compression methods that are not used in Zip.
@kylerchin also mentioned the use of LZMA Nested Feeds in SEPTA's GTFS Feed.
image
Do we have any ideas for an alternate crate?
Thanks.
Edit: Looks like no current GTFS provider has compressed their feed using anything other than store or deflate.
#153 (comment)

@kylerchin
Copy link
Contributor

The user should handle edge cases where there are nested zip libraries.

@lolpro11
Copy link
Author

lolpro11 commented Feb 12, 2024

The user should handle edge cases where there are nested zip libraries.

Example:

let (gtfs_bus, gtfs_rail) = GTFS::from_multizip()

Still user directed, but for cases like SEPTA where it might be useful for testing in cargo test
A better idea would be returning a Vec with the GTFS structs because my example would only return the 2 GTFS structs.

@kylerchin
Copy link
Contributor

It is a single agency and the library should not be changed to accommodate a single agency's poor file distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants