Skip to content

Consider removing the default test_description.json or add ability to disable musl builds #176

@mtjhrc

Description

@mtjhrc

In the rust-vmm/vhost-device repository: I'm trying to move the vhost-user-gpu from the staging directory into the "main" directory:
rust-vmm/vhost-device#801

The problem is that staging uses a custom test configuration, where I have disabled building the gpu device with musl.
This device links a lot of native dependencies and I would like to build it only with the gnu libc. As far as I can tell this is currently not achievable. (or is it somehow?)

I also saw there is vhost-device-sound which seems to have the same problem with linking to native libraries, the solution there disables all of the backends on musl build except the "null" backend. (So I think the device is not really usable, only the unit tests run).
For the gpu device, I'd rather not build it with musl at all, otherwise all of the functionality has to be conditionally compiled with #[cfg(target_env = "gnu")] attributes. (this was discussed here: rust-vmm/vhost-device#797 (comment) )

So my proposal would be to just remove the default test_description.json and have a version of that for each repository (where it can be better configured). The other option could be some mechanism to disable musl builds for specific crates in the workspace - this seems more complicated though.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions