Have SimpleIommu depend on backend-mmap #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SimpleIommu` (part of the iommu.rs test module) is used only by `create_virt_memory()`, which in turn depends on the backend-mmap feature. Have `SimpleIommu` as a whole depend on it, too. Reported-by: Patrick Roy <[email protected]> Signed-off-by: Hanna Czenczek <[email protected]>
XanClic
requested review from
ShadowCurse,
alexandruag,
bonzini,
jiangliu and
roypat
as code owners
bonzini
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
SimpleIommu(part of the iommu.rs test module) is used only bycreate_virt_memory(), which in turn depends on the backend-mmap feature. HaveSimpleIommuas a whole depend on it, too.(Reported by @roypat in #363)
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test. (No functionality added/changed)
Release" section of CHANGELOG.md (if no such section exists, please create one).
(Nothing changed from last release)
unsafecode is properly documented. (None there)