fuzz: don't init mem as a reference

This is confusing because it looks like functions are not called with a reference to the memory but with a copy of it. This is caused by GuestMemory being a reference in its initialization. Signed-off-by: Andreea Florescu <[email protected]>
rust-vmm · Feb 17, 2023 · 3e201e0 · 3e201e0
1 parent dbf56a7
commit 3e201e0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/fuzz/fuzz_targets/virtio_queue.rs b/fuzz/fuzz_targets/virtio_queue.rs
@@ -15,8 +15,8 @@ fuzz_target!(|data: &[u8]| {
     // same descriptors multiple times when pop_descriptor is called in a loop after a reset.
     // In the normal operation of a device we would not start from address 0 anyway.
     let start_addr = GuestAddress(0x1000);
-    let m = &GuestMemoryMmap::<()>::from_ranges(&[(start_addr, 0x11000)]).unwrap();
-    let vq = MockSplitQueue::create(m, start_addr, DEFAULT_QUEUE_SIZE);
+    let m = GuestMemoryMmap::<()>::from_ranges(&[(start_addr, 0x11000)]).unwrap();
+    let vq = MockSplitQueue::create(&m, start_addr, DEFAULT_QUEUE_SIZE);
     let descriptors: Vec<Descriptor> = fuzz_input
         .descriptors
         .iter()
@@ -30,6 +30,6 @@ fuzz_target!(|data: &[u8]| {
     }
 
     if let Ok(mut q) = vq.create_queue() {
-        fuzz_input.functions.iter().for_each(|f| f.call(&mut q, m));
+        fuzz_input.functions.iter().for_each(|f| f.call(&mut q, &m));
     }
 });
diff --git a/fuzz/fuzz_targets/virtio_queue_ser.rs b/fuzz/fuzz_targets/virtio_queue_ser.rs
@@ -16,8 +16,8 @@ fuzz_target!(|data: &[u8]| {
     // same descriptors multiple times when pop_descriptor is called in a loop after a reset.
     // In the normal operation of a device we would not start from address 0 anyway.
     let start_addr = GuestAddress(0x1000);
-    let m = &GuestMemoryMmap::<()>::from_ranges(&[(start_addr, 0x11000)]).unwrap();
-    let vq = MockSplitQueue::create(m, start_addr, DEFAULT_QUEUE_SIZE);
+    let m = GuestMemoryMmap::<()>::from_ranges(&[(start_addr, 0x11000)]).unwrap();
+    let vq = MockSplitQueue::create(&m, start_addr, DEFAULT_QUEUE_SIZE);
 
     let descriptors: Vec<Descriptor> = fuzz_input
         .descriptors
@@ -32,6 +32,6 @@ fuzz_target!(|data: &[u8]| {
     let q_state: QueueState = fuzz_input.queue_state.into();
 
     if let Ok(mut q) = Queue::try_from(q_state) {
-        fuzz_input.functions.iter().for_each(|f| f.call(&mut q, m));
+        fuzz_input.functions.iter().for_each(|f| f.call(&mut q, &m));
     }
 });