You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
We have a default for ConfiguredSamplers, as well as a FromStr implementation for users to give in a sampler string. However, at the moment we do not have that default represented anywhere. It would be useful to write the default string down somewhere so users can edit and use it themselves.
An LLM-based conversion of the default leads to this (which matches the structure in the default code correctly):
Alright, I finally dug into this properly. I got some debugs on the configured sampler, and was able to reconstruct our default implementation from a string.
llm/crates/llm-base/src/samplers.rs
Line 95 in 18b2a7d
We have a default for ConfiguredSamplers, as well as a FromStr implementation for users to give in a sampler string. However, at the moment we do not have that default represented anywhere. It would be useful to write the default string down somewhere so users can edit and use it themselves.
An LLM-based conversion of the default leads to this (which matches the structure in the default code correctly):
However, the default (and therefore this string) contains both mirostat samplers, but sets
mirostat1
andmirostat2
to false:llm/crates/llm-base/src/samplers.rs
Lines 167 to 169 in 18b2a7d
So there's something going on that I'm missing, or there's something off about the current default implementation.
The text was updated successfully, but these errors were encountered: