add opt-in post-quantum KX feature flag #520
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
cpu
commented
Dec 29, 2024
When librustls is built with the `post-quantum` feature flag, the default `aws-lc-rs` cryptography provider will be augmented to offer the hybrid `X25519MLKEM768` key exchange by default in addition to the pre-existing classical KX algorithms. Similar support is added to the `rustls_default_fips_provider()` provider when both `fips` and `post-quantum` are enabled. When the `post-quantum` feature is available a `rustls_post_quantum_provider()` function is also provided to explicitly construct the PQ-enabled provider. Since the default provider is augmented the existing `client.c` and `server.c` examples benefit transparently when the `-DPOST_QUANTUM=on` CMake option is provided. Connect-test CI is updated to test a post-QC secure key exchange with `pq.cloudflareresearch.com` reports the correct KX on Windows/MacOS/Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: this is a draft while it takes a dep. override to use unreleased
rustls-post-quantum, blocked on a release w/ rustls/rustls#2288 See rustls/rustls#2293 for more context.When
librustlsis built with a newpost-quantumfeature flag the defaultaws-lc-rscryptography provider will be augmented to offer the hybridX25519MLKEM768key exchange by default in addition to the pre-existing classical KX algorithms usingrustls-post-quantum.Similar support is added to the
rustls_default_fips_provider()provider when bothfipsandpost-quantumare enabled. When thepost-quantumfeature is available arustls_post_quantum_provider()function is also provided to explicitly construct the PQ-enabled provider.Since the default provider is augmented the existing
client.candserver.cexamples benefit transparently when the-DPOST_QUANTUM=onCMake option is provided. CI is updated to test a post-QC secure key exchange usingclient.candpq.cloudflareresearch.com, checking that the output reports the correct KX on Windows/MacOS/Linux. This is done in the daily tests job since it relies on an external host. Here's an exemplar run from a manual invocation on this branch.Resolves #507